Merged
Conversation
anton-107
requested review from
andrewnester,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
force-pushed
the
ssh-connect-ux-spinners
branch
from
9b4dc5d to
f5a32d5
Compare
anton-107
force-pushed
the
ssh-connect-elapsed-time
branch
from
284aa8e to
c8eceee
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: c65e058
18 interesting tests: 9 SKIP, 7 KNOWN, 1 flaky, 1 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
7 tasks
pietern
reviewed
Mar 12, 2026
simonfaltum
previously approved these changes
Mar 12, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
[Agent Swarm Review] Verdict: Approved
- 0 Critical
- 0 Major
- 0 Gap
- 1 Nit
- 0 Suggestion
Clean addition of elapsed time tracking to spinners. The TrackElapsedTime() method is well-integrated into the Bubble Tea model. Minor note: the MM:SS format doesn't handle hours, but SSH connect operations shouldn't take that long.
anton-107
force-pushed
the
ssh-connect-elapsed-time
branch
from
c8eceee to
eb36b9e
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Move detailed diagnostic messages (SSH key paths, secrets scope, remote user/port, job submission details, upload progress) from cmdio.LogString to log.Infof so they only appear with --log-level=info. Add spinners for long-running operations: binary upload, cluster state check, job startup wait, and metadata polling. Keep concise user-facing step messages (Connecting, Uploading, Starting, Connected) for progress visibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> # Conflicts: # experimental/ssh/internal/client/client.go
- Use single sp.Close() after UploadTunnelReleases instead of duplicated calls - Use defer sp.Close() in ensureSSHServerIsRunning for consistent cleanup - Keep job run ID in cmdio.LogString so it's visible without --log-level=info Co-authored-by: Isaac
Add TrackElapsedTime() method to the spinner that shows a running MM:SS stopwatch next to the spinner message. The time updates on every spinner tick (200ms). Enable it for all SSH connect spinners so users can see how long each step has been running. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Show elapsed time as prefix (e.g., "00:15 ⣾ Starting SSH server...") so it doesn't jump around as the message changes - Replace TrackElapsedTime() method with WithElapsedTime() construction option - Remove elapsedTimeMsg in favor of setting startTime directly in the model Co-authored-by: Isaac
anton-107
force-pushed
the
ssh-connect-elapsed-time
branch
from
eb36b9e to
c65e058
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
approved these changes
Mar 17, 2026
Collaborator
|
Commit: 692886c
47 interesting tests: 20 flaky, 16 RECOVERED, 9 KNOWN, 1 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithElapsedTime()construction option to the spinner that shows a runningMM:SSstopwatch as a prefix00:15 ⣾ Starting SSH server...) so it stays pinned to the left as the message changesStacked on #4694
Test plan
databricks ssh connectand verify elapsed time appears as a prefix and ticks next to each spinnerWithElapsedTime()) are unaffected🤖 Generated with Claude Code